Skip to content

Bump CAPI to v1.8.8 #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump CAPI to v1.8.8 #5331

wants to merge 1 commit into from

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Dec 11, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAPI to v1.8.8.

Which issue(s) this PR fixes:

N/A, but see #5255 for prior art.

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Bump CAPI to v1.8.8

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2024
@mboersma
Copy link
Contributor Author

/cherry-pick release-1.17

@k8s-infra-cherrypick-robot
Copy link

@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma
Copy link
Contributor Author

/retest

AKS test flake is an actual random collision, or ...?

workload-identity is enabled...
Creating resource group 'capz-wi-16519' in 'francecentral'
Creating storage account 'capzcioidcissuer31778' in 'capz-wi-16519'
ERROR: (StorageAccountAlreadyTaken) The storage account named capzcioidcissuer31778 is already taken.
Code: StorageAccountAlreadyTaken
Message: The storage account named capzcioidcissuer31778 is already taken.

@codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (00dfab1) to head (b85bae1).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5331   +/-   ##
=======================================
  Coverage   52.43%   52.43%           
=======================================
  Files         272      272           
  Lines       29401    29401           
=======================================
  Hits        15417    15417           
  Misses      13178    13178           
  Partials      806      806

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma
Copy link
Contributor Author

/retest

@mboersma
Copy link
Contributor Author

/retitle Bump CAPI to v1.8.7

@k8s-ci-robot k8s-ci-robot changed the title Bump CAPI to v1.8.6 Bump CAPI to v1.8.7 Dec 20, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2024
@mboersma
Copy link
Contributor Author

/retitle Bump CAPI to v1.8.8

@k8s-ci-robot k8s-ci-robot changed the title Bump CAPI to v1.8.7 Bump CAPI to v1.8.8 Dec 30, 2024
@mboersma mboersma force-pushed the capi-one-eight-six branch from a7e30e3 to b85bae1 Compare January 3, 2025 15:06
@mboersma mboersma mentioned this pull request Jan 6, 2025
Closed
4 tasks
@nawazkh
Copy link
Member

nawazkh commented Jan 13, 2025

/test pull-cluster-api-provider-azure-apiversion-upgrade

@k8s-ci-robot
Copy link
Contributor

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apiversion-upgrade b85bae1 link true /test pull-cluster-api-provider-azure-apiversion-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nawazkh
Copy link
Member

nawazkh commented Jan 14, 2025 

  [FAILED] Timed out after 65.698s.
  Unexpected error:
      <errors.aggregate | len:1, cap:1>: 
      admission webhook "default.azuremachinepool.infrastructure.cluster.x-k8s.io" denied the request: failed to set default managed identity defaults: failed to find parent machine pool: failed to find parent MachinePool: failed to get MachinePool for clusterctl-upgrade-workload-cbgnyi-mp-0
      [
          <*errors.StatusError | 0xc000dc2820>{
              ErrStatus: {
                  TypeMeta: {Kind: "Status", APIVersion: "v1"},
                  ListMeta: {
                      SelfLink: "",
                      ResourceVersion: "",
                      Continue: "",
                      RemainingItemCount: nil,
                  },
                  Status: "Failure",
                  Message: "admission webhook \"default.azuremachinepool.infrastructure.cluster.x-k8s.io\" denied the request: failed to set default managed identity defaults: failed to find parent machine pool: failed to find parent MachinePool: failed to get MachinePool for clusterctl-upgrade-workload-cbgnyi-mp-0",
                  Reason: "Forbidden",
                  Details: nil,
                  Code: 403,
              },
          },
      ]
  occurred
  In [It] at: /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/e2e/clusterctl_upgrade.go:454 @ 01/13/25 20:04:31.844
   Full Stack Trace
    sigs.k8s.io/cluster-api/test/e2e.ClusterctlUpgradeSpec.func2()
    	/home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/e2e/clusterctl_upgrade.go:454 +0x2537

this happens at https://github.com/kubernetes-sigs/cluster-api/blob/199edc1e98f8d3a4cbc756a2216037e7bee5c2eb/test/e2e/clusterctl_upgrade.go#L452C1-L455C1

I wonder if the timeout is causing the issue. Maybe 1m is too short of a time for the management cluster webhooks to be up and running.

These seem to be hardcoded timeouts in the test. How do we generally plug in our values? update the go.mod with our local copy of CAPI ? or raise another branch in our fork of CAPI and reference it ?

@mboersma
Copy link
Contributor Author

This failure began with CAPI v1.8.6, just FYI. See also #5356.

@mboersma
Copy link
Contributor Author

I'm not sure how to override it if it's hard-coded like that... Perhaps the problem began with this PR?

@nawazkh nawazkh mentioned this pull request Jan 15, 2025
Closed
4 tasks
@nawazkh nawazkh mentioned this pull request Jan 15, 2025
Closed
4 tasks
@mboersma mboersma mentioned this pull request Jan 16, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marosset marosset Awaiting requested review from marosset

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mboersma @k8s-ci-robot @k8s-infra-cherrypick-robot @nawazkh